Proposed fix for missing WWW-Authenticate header #1877
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation does not include the WWW-Authenticate header when returning a 401 for missing/invalid credentials when attempting to access the token endpoints. This PR would change to use the standard BasicAuthenticationEntryPoint in order to populate this header correctly. Signed-off-by: Lucian Holland <[email protected]> Fixes-468
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
reviewed
Jan 16, 2025
| @@ -344,7 +355,9 @@ public void init(HttpSecurity httpSecurity) throws Exception { | |||
| ExceptionHandlingConfigurer<HttpSecurity> exceptionHandling = httpSecurity | |||
| .getConfigurer(ExceptionHandlingConfigurer.class); | |||
| if (exceptionHandling != null) { | |||
| exceptionHandling.defaultAuthenticationEntryPointFor(new HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED), | |||
| var entryPoint = new BasicAuthenticationEntryPoint(); | |||
There was a problem hiding this comment.
Please revert the changes in this class and instead add the fix here:
jgrandja
added
type: enhancement
jgrandja
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation does not include the WWW-Authenticate header when returning a 401 for missing/invalid credentials when attempting to access the token endpoints. This PR would change to use the standard BasicAuthenticationEntryPoint in order to populate this header correctly.
I will add testing if the fix approach is considered acceptable